Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdl-sound callback doesn't fill in silence #1386

Open
flambard-took opened this issue Apr 26, 2020 · 0 comments
Open

sdl-sound callback doesn't fill in silence #1386

flambard-took opened this issue Apr 26, 2020 · 0 comments

Comments

@flambard-took
Copy link
Member

This is a very obvious and stupid bug, which somehow escaped notice, but finally manifested on Android (probably due to a larger audio buffer): in SDL audio callback you're supposed to fill in the silence bytes when you don't have enough sound to play. Failing to do so leads to garbage in the sound buffer, and consequently clicking/popping sounds being played after each sound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant